From a9df6135afc96607fbb8d576c944cedf91e36948 Mon Sep 17 00:00:00 2001
From: Eltrac <hi@guhub.cn>
Date: Wed, 10 Sep 2025 19:32:10 +0800
Subject: style: less redundant code and clearer logic

Former-commit-id: cac65038abbd13e2891f0084499ee82d9c67fb72
---
 assets/js/settings.js | 17 ++++++++---------
 1 file changed, 8 insertions(+), 9 deletions(-)

diff --git a/assets/js/settings.js b/assets/js/settings.js
index f785a705..a640ca24 100644
--- a/assets/js/settings.js
+++ b/assets/js/settings.js
@@ -60,7 +60,6 @@
 
       // initialize checkbox options
       function initCheckboxes() {
-        const checkboxes = document.querySelectorAll('#checkbox-options input[type="checkbox"]');
         const checkboxOptions = [
           {
             id: 'dontAllowTracking',
@@ -84,6 +83,14 @@
           element.checked = localStorage.getItem(checkboxOption.storage) ||
             checkboxOption.default === 'true';
 
+          // add event listener to checkbox
+          element.addEventListener('change', () => {
+            if (element.checked)
+              localStorage.setItem(checkboxOption.storage, 1);
+            else
+              localStorage.removeItem(checkboxOption.storage);
+          });
+
           // create label
           const label = document.createElement('label');
           label.htmlFor = element.id;
@@ -95,14 +102,6 @@
           wrapper.appendChild(element);
           wrapper.appendChild(label);
 
-          // add event listener to checkbox
-          element.addEventListener('change', () => {
-            if (element.checked)
-              localStorage.setItem(checkboxOption.storage, 1);
-            else
-              localStorage.removeItem(checkboxOption.storage);
-          });
-
           // append checkbox and label to container
           const container = document.getElementById('checkbox-options');
           container.appendChild(wrapper);
-- 
cgit v1.2.3