From 165abe4eaf4597d7b8e64ec245bd2036a3ec02df Mon Sep 17 00:00:00 2001 From: Eltrac Date: Wed, 10 Sep 2025 18:18:32 +0800 Subject: refactor: use existence instead of boolean string in local storage Umami needs `umami.disabled` value to be `1` to actually disable it. Also, local storage can't store booleans, hence 'true' and 'false' are stored as strings, which is dumb. Just remove the item when it needs to be set false. --- assets/js/settings.js | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) (limited to 'assets/js/settings.js') diff --git a/assets/js/settings.js b/assets/js/settings.js index 053786d6..52675143 100644 --- a/assets/js/settings.js +++ b/assets/js/settings.js @@ -96,7 +96,10 @@ // add event listener to checkbox element.addEventListener('change', () => { - localStorage.setItem(checkboxOption.storage, element.checked); + if (element.checked) + localStorage.setItem(checkboxOption.storage, 1); + else + localStorage.removeItem(checkboxOption.storage); }); // append checkbox and label to container -- cgit v1.2.3