summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorEltrac <hi@guhub.cn>2025-09-10 18:18:32 +0800
committerEltrac <hi@guhub.cn>2025-09-10 18:18:32 +0800
commit165abe4eaf4597d7b8e64ec245bd2036a3ec02df (patch)
tree67c085ef51d76d66fafa48c50ce18703cf1cc7e8
parent526216eaab32a9ca05662eaaba20660b94da904e (diff)
refactor: use existence instead of boolean string in local storage
Umami needs `umami.disabled` value to be `1` to actually disable it. Also, local storage can't store booleans, hence 'true' and 'false' are stored as strings, which is dumb. Just remove the item when it needs to be set false.
-rw-r--r--assets/js/settings.js5
-rw-r--r--layouts/_partials/components/back-to-top.html2
2 files changed, 5 insertions, 2 deletions
diff --git a/assets/js/settings.js b/assets/js/settings.js
index 053786d6..52675143 100644
--- a/assets/js/settings.js
+++ b/assets/js/settings.js
@@ -96,7 +96,10 @@
// add event listener to checkbox
element.addEventListener('change', () => {
- localStorage.setItem(checkboxOption.storage, element.checked);
+ if (element.checked)
+ localStorage.setItem(checkboxOption.storage, 1);
+ else
+ localStorage.removeItem(checkboxOption.storage);
});
// append checkbox and label to container
diff --git a/layouts/_partials/components/back-to-top.html b/layouts/_partials/components/back-to-top.html
index ea990f93..bf094d5d 100644
--- a/layouts/_partials/components/back-to-top.html
+++ b/layouts/_partials/components/back-to-top.html
@@ -15,7 +15,7 @@
<script>
// hide Batrick if set
-if (localStorage.getItem('geedeapro.ui.hideBatrick') === 'true') {
+if (localStorage.getItem('geedeapro.ui.hideBatrick')) {
document.getElementById('back2top').classList.add('hidden');
} else {
// Batrick functionality